Remove Codecov failure override - #810
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
=========================================
Coverage 96.29% 96.29%
Complexity 1154 1154
=========================================
Files 124 124
Lines 3540 3540
=========================================
Hits 3409 3409
Misses 131 131 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit codecovFailCiIfError: false override from the GitHub Actions PHPUnit workflow jobs so that the default behavior from the shared yiisoft/actions reusable workflow is applied.
Changes:
- Removed
codecovFailCiIfError: falsefrom thephpunitjob inputs. - Removed
codecovFailCiIfError: falsefrom thephpunit-without-intljob inputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vjik
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the explicit codecovFailCiIfError override from the PHPUnit workflow so the shared workflow default is used. Validation: git diff --check.